Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine-lol could not run due to modify_ldt being banned by flatpak #85

Closed
alaviss opened this issue Dec 24, 2019 · 13 comments
Closed

wine-lol could not run due to modify_ldt being banned by flatpak #85

alaviss opened this issue Dec 24, 2019 · 13 comments
Labels
sandbox This has something to do with sandbox limitations

Comments

@alaviss
Copy link

alaviss commented Dec 24, 2019

Describe the problem
The patch for League of Legends in lutris wine uses the LDT to store data. The syscall responsible for this (modify_ldt) is however banned by flatpak via seccomp, causing wine to not be able to launch any application.

Is it reproducible with native Lutris?
No

Steps to reproduce

  1. Install League of Legends

Expected behavior
League of Legends is installed

Actual behavior

2019-12-24 07:03:33,926: Runner %s needs to be installed
2019-12-24 07:03:33,933: Getting runner information for wine (version: lutris-lol-4.20-x86_64)
2019-12-24 07:04:01,127: Downloading file 1 of 1

(lutris:2): Gtk-CRITICAL **: 07:04:04.340: gtk_tree_model_get_column_type: assertion 'GTK_IS_TREE_MODEL (tree_model)' failed

(lutris:2): Gtk-CRITICAL **: 07:04:04.340: gtk_combo_box_get_active_id: assertion 'gtk_tree_model_get_column_type (model, column) == G_TYPE_STRING' failed
2019-12-24 07:04:04,347: Creating a win32 prefix in /home/alaviss/Games/league-of-legends-test
2019-12-24 07:04:09,730: Wine prefix creation is taking longer than expected...
2019-12-24 07:04:16,991: No user.reg found after prefix creation. Prefix might not be valid
2019-12-24 07:04:17,206: Creating a win32 prefix in /home/alaviss/Games/league-of-legends-test
2019-12-24 07:04:22,490: Wine prefix creation is taking longer than expected...
2019-12-24 07:04:29,751: No user.reg found after prefix creation. Prefix might not be valid
2019-12-24 07:04:30,076: The game doesn't have an executable
Running /home/alaviss/.var/app/net.lutris.Lutris/data/lutris/runtime/winetricks/winetricks --unattended d3dcompiler_43 d3dx9
ls: cannot access '/home/alaviss/Games/league-of-legends-test/drive_c': No such file or directory
grep: /home/alaviss/Games/league-of-legends-test/*.reg: No such file or directory
------------------------------------------------------
WINEPREFIX INFO:
Drive C:

Registry info:
/home/alaviss/Games/league-of-legends-test/*.reg:
------------------------------------------------------
------------------------------------------------------
/home/alaviss/.var/app/net.lutris.Lutris/data/lutris/runners/wine/lutris-lol-4.20-x86_64/bin/wine cmd.exe /c echo '%ProgramFiles%' returned empty string, error message "modify_ldt: Operation not permitted"
------------------------------------------------------
Waiting on children
Exit with returncode 1
2019-12-24 07:04:32,106: Creating a win32 prefix in /home/alaviss/Games/league-of-legends-test
2019-12-24 07:04:37,384: Wine prefix creation is taking longer than expected...
2019-12-24 07:04:44,646: No user.reg found after prefix creation. Prefix might not be valid
Running /home/alaviss/.var/app/net.lutris.Lutris/data/lutris/runners/wine/lutris-lol-4.20-x86_64/bin/wine /home/alaviss/.var/app/net.lutris.Lutris/cache/lutris/installer/league-of-legends/lol_installer/League%20of%20Legends%20installer%20NA.exe
modify_ldt: Operation not permitted
Waiting on children
Exit with returncode -11

Flatpak info
flatpak --version

Flatpak 1.4.3

flatpak --gl-drivers

default
host
@gasinvein
Copy link
Member

Thanks for the report. However, I don't think it's possible to fix this on our side. Is the syscall really essential for the wine build to work?

@gasinvein gasinvein added the sandbox This has something to do with sandbox limitations label Dec 24, 2019
@alaviss
Copy link
Author

alaviss commented Dec 24, 2019 via email

@eszlari
Copy link

eszlari commented Mar 22, 2020

@alaviss Consider opening an issue under: https://github.com/flatpak/flatpak/issues

@TheGreatestJannet
Copy link

Is this still an issue? I'm looking to run league of legends in a sandbox.

@ilkekaratas
Copy link

Hello! how did you patch out the ban? I am trying to set League on PS4 gentoo but I get this error. Can you please tell?

@alaviss
Copy link
Author

alaviss commented May 31, 2021

Hello! how did you patch out the ban? I am trying to set League on PS4 gentoo but I get this error. Can you please tell?

Removing these lines should do:
https://github.com/flatpak/flatpak/blob/6f86a8ff423a2e7a8e1db70c69612f3fa49ae9d4/common/flatpak-run.c#L2899-L2901

@alaviss alaviss mentioned this issue May 31, 2021
Closed
@mirkobrombin mirkobrombin mentioned this issue Aug 12, 2021
Closed
@xerz-one xerz-one mentioned this issue Dec 28, 2021
Closed
@ghost ghost mentioned this issue Jan 24, 2022
Merged
@nhubaotruong nhubaotruong mentioned this issue Mar 28, 2022
Closed
@mirkobrombin mirkobrombin mentioned this issue Apr 12, 2022
Closed
@strycore strycore mentioned this issue Apr 12, 2022
Closed
@TheNamelessWonderer TheNamelessWonderer mentioned this issue Jul 29, 2022
Closed
@Tank743
Copy link

Tank743 commented Jul 31, 2022

Hello! how did you patch out the ban? I am trying to set League on PS4 gentoo but I get this error. Can you please tell?

Removing these lines should do: https://github.com/flatpak/flatpak/blob/6f86a8ff423a2e7a8e1db70c69612f3fa49ae9d4/common/flatpak-run.c#L2899-L2901

How do you access the code to remove those lines?

@alaviss
Copy link
Author

alaviss commented Jul 31, 2022

Hello! how did you patch out the ban? I am trying to set League on PS4 gentoo but I get this error. Can you please tell?

Removing these lines should do: https://github.com/flatpak/flatpak/blob/6f86a8ff423a2e7a8e1db70c69612f3fa49ae9d4/common/flatpak-run.c#L2899-L2901

How do you access the code to remove those lines?

You'd have to build your own flatpak package. This differs a whole lot between distributions.

For Gentoo at least, I can just put a patch file at the right location and it will apply it automatically to every version of flatpak that I build.

@GustavoPeredo GustavoPeredo mentioned this issue Aug 6, 2022
Merged
5 tasks
@mirkobrombin mirkobrombin mentioned this issue Aug 22, 2022
Closed
This was referenced Aug 24, 2022
Closed
Closed
Closed
@losuler
Copy link

losuler commented Sep 6, 2022

This should now be fixed, now that flatpak/flatpak#5082 has been merged!

@alaviss
Copy link
Author

alaviss commented Sep 6, 2022

Yep, looks like flatpak 1.15.0 will include this fix 🎉

@alaviss alaviss closed this as completed Sep 6, 2022
@Konglomneshued
Copy link

Konglomneshued commented Oct 29, 2022 •
edited

Still have this issue.... [On Flatpak], .deb works

Screenshot from 2022-10-29 13-28-29

@alaviss
Copy link
Author

alaviss commented Nov 3, 2022

That's to be expected, the patch fixing this bug has not made it to a stable flatpak release yet.

@Fabianoshz
Copy link

Fabianoshz commented Nov 5, 2022 •
edited

I'm using 1.15 and I still have this issue

Edit: nvm, started my PC again today and tested it, seems to be working.

@TheFrenchGhosty TheFrenchGhosty mentioned this issue Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sandbox This has something to do with sandbox limitations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@gasinvein @alaviss @losuler @ilkekaratas @Fabianoshz @eszlari @TheGreatestJannet @Konglomneshued @Tank743